Compare commits

...
1 Commits
Author SHA1 Message Date
Qiufeng 6c96cddd4e fix: reconcile stale staged updates
TallyNote release / linux-x64 (push) Successful in 6m50s
2026-09-05 16:31:53 +08:00
4 changed files with 20 additions and 5 deletions
+1 -1
View File
@@ -1,6 +1,6 @@
{
"name": "tallynote",
"version": "1.2.5",
"version": "1.2.6",
"private": true,
"type": "module",
"packageManager": "pnpm@9.0.6",
+3 -1
View File
@@ -58,6 +58,7 @@ import { isNewerVersion } from "./update.js";
import {
ACTIVE_UPDATE_STATUSES,
checkForUpdate,
currentReleaseVersion,
publicCheckFromCache,
publicUpdateJob,
reconcileOrphanedUpdateJobs,
@@ -1016,7 +1017,8 @@ export async function buildApp(database: DatabaseContext, config: AppConfig) {
// A package may have been downloaded before the host was upgraded by
// another path. Never apply a staged archive that is no longer newer
// than the release currently serving traffic.
if (!isNewerVersion(config.appVersion, staged.version)) {
const effectiveCurrentVersion = currentReleaseVersion(config) ?? config.appVersion;
if (!isNewerVersion(effectiveCurrentVersion, staged.version)) {
const now = Date.now();
database.sqlite.prepare("UPDATE update_jobs SET status='failed', error_message=?, completed_at=?, updated_at=? WHERE id=? AND status='staged'").run("暂存更新已过期,当前版本无需再次升级", now, now, stagedJobId);
throw new AppError(409, "UPDATE_NOT_AVAILABLE", "暂存更新已过期,请重新检查更新");
+3 -2
View File
@@ -439,7 +439,7 @@ function recoveryStateJobId(filePath: string): string | null {
}
}
function currentReleaseVersion(config: AppConfig): string | null {
export function currentReleaseVersion(config: AppConfig): string | null {
try {
const target = realpathSync(config.currentLink);
const releases = realpathSync(config.releasesDir);
@@ -498,7 +498,8 @@ export function reconcileOrphanedUpdateJobs(database: Database.Database, config:
// completes the same release) before returning to this page. Treat the
// archive as an expired terminal task so it cannot keep blocking the
// queue or appear as an "apply" action for the current version.
if (row.status === "staged" && !isNewerVersion(config.appVersion, row.version) && !matchingFreshRequest && !matchingFreshState) {
const effectiveCurrentVersion = releaseVersion ?? config.appVersion;
if (row.status === "staged" && !isNewerVersion(effectiveCurrentVersion, row.version) && !matchingFreshRequest && !matchingFreshState) {
const changed = database.transaction(() => {
const result = database.prepare(`
UPDATE update_jobs
+13 -1
View File
@@ -451,7 +451,19 @@ export default function UpdatePage({
setError("");
try {
const result = await api<UpdateInfo>("/api/update/check", { method: "POST" });
mergeInfo(result, true);
// A check response is authoritative for release availability. It does
// not include a job field, so retain a task only while it is still
// actionable; the status endpoint has already reconciled expired
// staged tasks before this check runs.
setLiveInfo((current) => ({
...(current ?? result),
...result,
job: current?.job && (
current.job.status === "completed" ||
(current.job.status !== "staged" || current.job.operation !== "download") ||
(result.latest?.isNewer === true && result.latest.version === current.job.version)
) ? current.job : null,
}));
notify?.("版本检查完成", "info");
} catch (e) {
if (e instanceof ApiError && e.status === 429) {